Skip to content

feat: 🎸 create table component and test in order #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
kenmaqqe wants to merge 22 commits into
base: dev
Choose a base branch
from
Draft

feat: 🎸 create table component and test in order #21

kenmaqqe wants to merge 22 commits into from

Conversation

@kenmaqqe
Copy link
Collaborator

@kenmaqqe kenmaqqe commented May 26, 2025

Create in ui-shared our table components and testing they in order page with mock data

@kenmaqqe
feat: 🎸 create table component and test in order
e5ba0ca 
Create in ui-shared our table components and testing they in order page
with mock data
@Tornik73
Copy link
Member

Tornik73 commented May 26, 2025 •
edited
Loading

🎉 Snyk checks have passed. No issues have been found so far.

✅ security/snyk check is complete. No issues have been found. (View Details)

@kenmaqqe
feat: 🎸 add sort component
690b537 
create sort component using ant design library
Tornik73
Tornik73 requested changes May 26, 2025
View reviewed changes
Tornik73
Tornik73 reviewed Jun 2, 2025
View reviewed changes
Tornik73
Tornik73 reviewed Jun 2, 2025
View reviewed changes
Tornik73
Tornik73 requested changes Jun 18, 2025
View reviewed changes
Tornik73
Tornik73 requested changes Jun 25, 2025
View reviewed changes
@kenmaqqe
Copy link
Collaborator Author

kenmaqqe commented Jun 30, 2025

i think for delete we can make universal DeleteModal, but for editing we wanna create different modals component or what? write all logic, form and another in page?

@kenmaqqe
Copy link
Collaborator Author

kenmaqqe commented Jun 30, 2025

AddModal maybe only for products, edit for user and product. OrderPage must have only delete

@kenmaqqe
Copy link
Collaborator Author

kenmaqqe commented Jun 30, 2025

And what we go post on our DashboardPage?

Tornik73
Tornik73 requested changes Jul 1, 2025
View reviewed changes
@kenmaqqe
fix: 🐛 resolve changes
d55d64b 
resolve changes

BREAKING CHANGE: 🧨 resolve changes

✅ Closes: resolve changes
@kenmaqqe
Copy link
Collaborator Author

kenmaqqe commented Jul 1, 2025

i add logic to editOrderModal but i think we don`t need this modal, what u think about it?

Tornik73
Tornik73 requested changes Jul 2, 2025
View reviewed changes
@Tornik73
Copy link
Member

Tornik73 commented Jul 2, 2025

i think for delete we can make universal DeleteModal, but for editing we wanna create different modals component or what? write all logic, form and another in page?

You can use your base modal, but pass forms and buttons in the children

@Tornik73
Copy link
Member

Tornik73 commented Jul 2, 2025

And what we go post on our DashboardPage?

Firstly we need to understand which data we have
I suppose it will some charts there
Like how much products, users etc we have
image
image

Tornik73
Tornik73 requested changes Jul 23, 2025
View reviewed changes
apps/fe-admin/src/pages/OrderPage/OrderPage.tsx
});

const handleDelete = (id: number) => {
setOrderData(orderData.filter((item) => item.id !== id));
Copy link
Member

@Tornik73 Tornik73 Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use prev value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Tornik73 Tornik73 Tornik73 requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kenmaqqe @Tornik73